Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal example for using ET and AOTI #763

Merged
merged 2 commits into from
May 13, 2024
Merged

Minimal example for using ET and AOTI #763

merged 2 commits into from
May 13, 2024

Conversation

mikekgfb
Copy link
Contributor

Added to parking_lot from back-level unmodified pre-llama3 runner
Might move to torchchat/unsupported or to a separate PyTorch tutorial or repo

Advantageously, in torchchat we could run some CI, and have the infra to build models.
If we decide not to include it as unsupported example in torchchat, make it a separate tutorial?

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label May 12, 2024
@mikekgfb
Copy link
Contributor Author

mikekgfb commented May 12, 2024

@mergennachin @byjlw @malfet

I would love to get your ideas, advice and perspectives on what to do with Andrej's original runner, enabled for DSO and PTE execution, in the long-term.

I think this example is super instructive and useful because it answers the question "what is the minimum amount of work I have to do to support both DSO and PTE models from my own native application". In many ways, it's a lesser runner/run.cpp but instructive because of its bare-boneness, which is a mark of Andrej's genius to explaining this field to people.

That being said, I'm struggling with defining the relationship of this example to the rest of torchchat and how to make this available to the public at large as an example, not a supported feature. (Nikita had suggested for another similar scenario to create an experimental directory to gather such examples.)

I can see this being an example like we have in ExecuTorch but targeting server to mobile integration, or a PyTorch.org tutorial. Curious to get your thoughts and perspective.

@mikekgfb mikekgfb merged commit 6a8c384 into main May 13, 2024
36 checks passed
@mikekgfb mikekgfb deleted the minimal_example branch May 13, 2024 00:42
@mikekgfb
Copy link
Contributor Author

Thank you @iseeyuan !

malfet pushed a commit that referenced this pull request Jul 17, 2024
* minimal example for enabling Andrej's runner, from commit 2d47702

* Minimal example
malfet pushed a commit that referenced this pull request Jul 17, 2024
* minimal example for enabling Andrej's runner, from commit 2d47702

* Minimal example
malfet pushed a commit that referenced this pull request Jul 17, 2024
* minimal example for enabling Andrej's runner, from commit 2d47702

* Minimal example
malfet pushed a commit that referenced this pull request Jul 17, 2024
* minimal example for enabling Andrej's runner, from commit 2d47702

* Minimal example
malfet pushed a commit that referenced this pull request Jul 17, 2024
* minimal example for enabling Andrej's runner, from commit 2d47702

* Minimal example
malfet pushed a commit that referenced this pull request Jul 17, 2024
* minimal example for enabling Andrej's runner, from commit 2d47702

* Minimal example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants